Skip to content

chore: update codeowners #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jackw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update codeowners #2441

jackw wants to merge 2 commits into from
+14 −4

Conversation

@jackw
Copy link
Collaborator

@jackw jackw commented Feb 6, 2026

What this PR does / why we need it:

Team splits n responsibilities mean we need to reassess the codeowners file. This PR attempts to address the new responsibilities. Likely needs some fine tuning. 🆘

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw self-assigned this Feb 6, 2026
@jackw jackw requested review from a team as code owners February 6, 2026 16:27
@jackw jackw requested a review from leventebalogh February 6, 2026 16:27
Copilot AI review requested due to automatic review settings February 6, 2026 16:27
@jackw jackw added chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations labels Feb 6, 2026
@jackw jackw requested review from academo, briangann and xnyo February 6, 2026 16:27
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository-wide ownership rules by revising .github/CODEOWNERS to reflect new team responsibilities and add more granular ownership for specific packages and docs paths.

Changes:

  • Replaces the previous default owner teams with new default owners.
  • Adds per-directory ownership entries for various packages and the Docusaurus website.
  • Introduces CODEOWNERS entries for plugin-meta-extractor and plugin-types-bundler (currently without owners).

.github/CODEOWNERS Outdated
Comment on lines 4 to 13
./packages/create-plugin @grafana/grafana-frontend-platform
./packages/eslint-plugin-plugins @grafana/plugins-platform-frontend
./packages/plugin-docs-renderer @grafana/plugins-platform-frontend
./packages/plugin-e2e @grafana/plugins-platform-frontend
./packages/plugin-meta-extractor
./packages/plugin-types-bundler
./packages/react-detect @grafana/grafana-frontend-platform
./packages/tsconfig @grafana/grafana-frontend-platform

./docusaurus/website @grafana/grafana-frontend-platform
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory patterns are prefixed with ./ (e.g., ./packages/create-plugin). CODEOWNERS patterns follow gitignore-style matching and are evaluated relative to the repo root; the ./ prefix typically won’t match any path in the repo and can cause these rules to be ignored. Use root-relative patterns like /packages/create-plugin/ (and similarly for the other entries).

Suggested change
./packages/create-plugin @grafana/grafana-frontend-platform
./packages/eslint-plugin-plugins @grafana/plugins-platform-frontend
./packages/plugin-docs-renderer @grafana/plugins-platform-frontend
./packages/plugin-e2e @grafana/plugins-platform-frontend
./packages/plugin-meta-extractor
./packages/plugin-types-bundler
./packages/react-detect @grafana/grafana-frontend-platform
./packages/tsconfig @grafana/grafana-frontend-platform
./docusaurus/website @grafana/grafana-frontend-platform
/packages/create-plugin/ @grafana/grafana-frontend-platform
/packages/eslint-plugin-plugins/ @grafana/plugins-platform-frontend
/packages/plugin-docs-renderer/ @grafana/plugins-platform-frontend
/packages/plugin-e2e/ @grafana/plugins-platform-frontend
/packages/plugin-meta-extractor/
/packages/plugin-types-bundler/
/packages/react-detect/ @grafana/grafana-frontend-platform
/packages/tsconfig/ @grafana/grafana-frontend-platform
/docusaurus/website/ @grafana/grafana-frontend-platform

Copilot uses AI. Check for mistakes.
.github/CODEOWNERS Outdated
Comment on lines 8 to 9
./packages/plugin-meta-extractor
./packages/plugin-types-bundler
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These CODEOWNERS entries have no owners specified. Lines without at least one valid owner are ignored (and can make ownership coverage incomplete). Either add the intended team/user owners for these paths or remove the lines.

Suggested change
./packages/plugin-meta-extractor
./packages/plugin-types-bundler
./packages/plugin-meta-extractor @grafana/plugins-platform-frontend
./packages/plugin-types-bundler @grafana/plugins-platform-frontend

Copilot uses AI. Check for mistakes.
.github/CODEOWNERS Outdated
./packages/react-detect @grafana/grafana-frontend-platform
./packages/tsconfig @grafana/grafana-frontend-platform

./docusaurus/website @grafana/grafana-frontend-platform
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path pattern is also prefixed with ./, which may prevent it from matching under CODEOWNERS rules. Consider changing to a root-relative pattern like /docusaurus/website/ so ownership is applied as intended.

Suggested change
./docusaurus/website @grafana/grafana-frontend-platform
/docusaurus/website/ @grafana/grafana-frontend-platform

Copilot uses AI. Check for mistakes.
@grafana-plugins-platform-bot grafana-plugins-platform-bot bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Feb 6, 2026
@hugohaggmark
Copy link
Contributor

hugohaggmark commented Feb 9, 2026

Similar PR for grafana/grafana: grafana/grafana#117572

sunker
sunker reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should probably put grafana/plugins-platform-frontend next to the plugin-types-bundler since it's related to ui extensions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunker sunker sunker left review comments

Copilot code review Copilot Copilot left review comments

@leventebalogh leventebalogh Awaiting requested review from leventebalogh leventebalogh is a code owner automatically assigned from grafana/plugins-platform-frontend

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-backend

@briangann briangann Awaiting requested review from briangann briangann is a code owner automatically assigned from grafana/plugins-platform-backend

@xnyo xnyo Awaiting requested review from xnyo xnyo is a code owner automatically assigned from grafana/plugins-platform-backend

At least 1 approving review is required to merge this pull request.

Assignees

@jackw jackw

Labels

chore Other changes that don't modify src or test files no-changelog Don't include in changelog and version calculations

Projects

Grafana Catalog Team
Status: 🔬 In review
Grafana Frontend Platform
Status: 🔍 In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackw @hugohaggmark @sunker